Improved inference of archive names #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add list of allowed file name extensions - allow to provide archive name explicitly on the command line
adamant-pwn
suggested changes
Nov 18, 2024
Co-authored-by: Oleksandr Kulkov <[email protected]>
Co-authored-by: Oleksandr Kulkov <[email protected]>
- renamed the already existint filename_without_archive_extensions to filename_without_archive_extensions_multipart
adamant-pwn
suggested changes
Nov 19, 2024
archiver/main.py
Outdated
| @@ -160,6 +160,7 @@ def parse_arguments(args): | |||
| parser_check.add_argument("archive_dir", type=str, help="Select source archive directory or .tar.lz file") | |||
| parser_check.add_argument("-d", "--deep", action="store_true", help="Verify integrity by unpacking archive and hashing each file") | |||
| parser_check.add_argument("-n", "--threads", type=int, help=thread_help) | |||
| parser_check.add_argument("--archive_name", type=str, help="Provide explicit source name of the archive (if automatic detection fails") | |||
There was a problem hiding this comment.
Should we add a test case that covers this scenario?
- changed from archive_name to archive-name on CLI - fixed passing of information for the "extract" case - added small test data with incompatible project name (containing ".part1" suffix) - added test case to verify that option is considered appropriately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.